Fix e2e failures on 'Front Page' template. #28638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addison-Stavlo
requested review from
ajitbohra,
nerrad and
ntwb
as code owners
Addison-Stavlo
requested review from
ockham,
vindl,
jeyip,
mattwiebe,
david-szabo97 and
Copons
jeyip
reviewed
Feb 1, 2021
6 tasks
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
ockham
added
[Package] E2E Tests
vindl
approved these changes
Feb 1, 2021
|
We're seeing a new e2e spec failure on this PR. For some reason, the navigation editor is getting stuck on the "Experiment settings" screen (this was pulled form failure artifacts in the failed e2e job)
This PR does, however, successfully remove a large swath of existing failures, so +1 from me. |
jeyip
approved these changes
Feb 1, 2021
|
Thanks a lot, y'all! ❤️ |
6 tasks
|
For a late post-mortem post-scriptum: The |
noisysocks
pushed a commit
that referenced
this pull request
Feb 5, 2021
Attempting to fix e2e failures on a "Front Page" template selector. It looks like tt1-blocks no longer supplies a front-page template, and using Index should work as the tests were not reliant on the specific template.
noisysocks
pushed a commit
that referenced
this pull request
Feb 5, 2021
Attempting to fix e2e failures on a "Front Page" template selector. It looks like tt1-blocks no longer supplies a front-page template, and using Index should work as the tests were not reliant on the specific template.
noisysocks
pushed a commit
that referenced
this pull request
Feb 7, 2021
Attempting to fix e2e failures on a "Front Page" template selector. It looks like tt1-blocks no longer supplies a front-page template, and using Index should work as the tests were not reliant on the specific template.
noisysocks
pushed a commit
that referenced
this pull request
Feb 8, 2021
Attempting to fix e2e failures on a "Front Page" template selector. It looks like tt1-blocks no longer supplies a front-page template, and using Index should work as the tests were not reliant on the specific template.
ockham
added a commit
that referenced
this pull request
Feb 9, 2021
Gutenberg's end-to-end tests were broken for a while after TT1 Blocks removed their `front-page` template (WordPress/theme-experiments#179) -- which our e2e tests relied on. This was fixed on the Gutenberg side in #28638. Per [this discussion](#28692 (comment)), we might be able to avoid a similar situation in the future by pinning our TT1 Blocks dependency to a given version. See #28692 for more background.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempting to fix e2e failures on a "Front Page" template selector. It looks like tt1-blocks no longer supplies a front-page template, and using Index should work as the tests were not reliant on the specific template.
🤞 on CI checks.
How has this been tested?
Screenshots
Types of changes
Checklist: