Group Block: Add support for custom border settings #29591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
the
Global Styles
scruffian
force-pushed
the
add/custom-border-settings-for-group
branch
from
55f2f95 to
760c685
Compare
|
Size Change: +10 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Mar 8, 2021
I've asked here about how we should address the UI part of borders. As for adding this to the block level, we could do this one by one, to reduce review time and accelerate landing. I'd like to clarify some things about each of them. For example, I think border-radius and border-width are fine being inline styles. However, it seems to me that border-style can be expressed through classes and border-color can be expressed through classes (user chooses one of the preset colors) & inline styles (user chooses a custom color). |
|
@aaronrobertshaw I haven't found an issue for adding support for border, so I've created one at #29616 to track progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes it possible to customize the border settings of the group block. This is necessary for TT1-Blocks, which has a border-style for the group block
How has this been tested?
stylessection of theme.json:Screenshots
Now TT1 Blocks ground blocks look like this:
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: