Navigation Editor: use 'ajaxurl' global in batchSave action #31028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
Mamaduka
requested review from
adamziel,
draganescu,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
|
Size Change: +1.17 kB (0%) Total Size: 1.47 MB
ℹ️ View Unchanged
|
getdave
reviewed
Apr 21, 2021
getdave
approved these changes
Apr 26, 2021
There was a problem hiding this comment.
I tested this by following the instructions over at https://wordpress.org/support/article/giving-wordpress-its-own-directory/#method-i-without-url-change.
Menu saving and editing worked perfectly.
The ajaxurl was available on window. If I manually modified it to remove that property then the fallback also worked.
|
Thanks for the review, @getdave. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR fixes navigation saving issue when WordPress is in a subdirectory.
Fixes #25181.
How has this been tested?
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).