-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widget editor: Update toolbar and notice positioning. #31582
Merged
draganescu
merged 1 commit into
trunk
from
update/widget-screen-mobile-responsive-toolbar
May 10, 2021
Merged
Widget editor: Update toolbar and notice positioning. #31582
draganescu
merged 1 commit into
trunk
from
update/widget-screen-mobile-responsive-toolbar
May 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Task
Issues or PRs that have been broken down into an individual action to take
[Package] Edit Widgets
/packages/edit-widgets
labels
May 7, 2021
talldan
requested review from
adamziel,
draganescu,
kevin940726,
noisysocks and
tellthemachines
as code owners
May 7, 2021 07:51
talldan
changed the title
Widget editor: Fix toolbar and notice positioning.
Widget editor: Update toolbar and notice positioning.
May 7, 2021
Size Change: +3 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
May 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Edit Widgets
/packages/edit-widgets
[Type] Task
Issues or PRs that have been broken down into an individual action to take
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the edit widgets fixed toolbar positioning after #31134.
This just required some reordering of the components to more closely match the post editor. Notices have also been moved to render below the toolbar.
How has this been tested?
Screenshots
Before Before
Before (after before before)
After
Types of changes
Checklist:
*.native.js
files for terms that need renaming or removal).