Adapt the Gutenberg plugin's code to work with FSE infrastructure in Core. #32183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
Gutenberg Plugin
youknowriad
commented
May 25, 2021
| @@ -9,7 +9,7 @@ | |||
| /** | |||
| * Base Templates REST API Controller. | |||
| */ | |||
| class WP_REST_Templates_Controller extends WP_REST_Controller { | |||
| class Gutenberg_REST_Templates_Controller extends WP_REST_Controller { | |||
There was a problem hiding this comment.
Gutenberg plugin has more logic than core to support file templates... so it needs to use an alternative endpoint.
youknowriad
commented
May 25, 2021
lib/load.php
Outdated
| @@ -74,7 +72,7 @@ function gutenberg_is_experiment_enabled( $name ) { | |||
| } | |||
|
|
|||
| if ( ! class_exists( 'WP_Widget_Block' ) ) { | |||
| require_once __DIR__ . '/class-wp-widget-block.php'; | |||
| // require_once __DIR__ . '/class-wp-widget-block.php'; | |||
There was a problem hiding this comment.
This is temporary, waiting for #32176
|
Size Change: 0 B Total Size: 1.86 MB ℹ️ View Unchanged
|
|
This has been merged into #32176 to see if we can fix all the env/e2e issues. |
ellatrix
pushed a commit
that referenced
this pull request
May 25, 2021
…Core. (#32183) * Adapt the Gutenberg plugin's code to work with FSE infrastructure in Core * small changes coming from the merge ticket Co-authored-by: André <nosolosw@users.noreply.github.com>
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FSE infrastructure is going to be committed to Core soon and the Gutenberg plugin needs to be adapted in consequence to work for 5.8 and avoid breaking tests. (WordPress/wordpress-develop#1267)