Multi select: select all: restore ref callback #32318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Feature] Block Multi Selection
|
Size Change: +112 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
7 tasks
ellatrix
added a commit
that referenced
this pull request
Jul 15, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #31859.
This PR restores the ref callback we previously had to attach event handlers. Currently
useShortcutis used, which won't reattach handlers if the ref value changes. This stands in the way rewriting writing flow as a ref callback, which should not break if the ref changes.Introduces
__unstableUseShortcutEventMatch, which works regardless of whether an event is synthetic or not. If the future, this could enable us to attach shortcut event handlers to React events, which bubble through portals, so there would be no need to bubble native events through the iframe.Not only is this an important thing to have for the iframe, it will also prove to be an important in contextualising (or localising) all editor shortcuts, which are now all global as they are bound to the
document. This is important because you may have other things on the page beside the block editor, or multiple block editors. Shortcuts should only work if focus is within a certain context.How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).