Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show widgets in menu without theme support #32420

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

tellthemachines
Copy link
Contributor

@tellthemachines tellthemachines commented Jun 3, 2021

Description

Fixes #26153 with older versions of core. WordPress/wordpress-develop#1308 has fixed the issue for the new widgets screen in core.

How has this been tested?

Activate a theme with no support for widgets.
Verify the link to the widgets screen doesn't show in the menu under "Appearance".
Verify that going directly to wp-admin/themes.php?page=gutenberg-widgets shows "Sorry, you are not allowed to access this page.".

Screenshots

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@tellthemachines tellthemachines added [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Type] Bug An existing feature does not function as intended labels Jun 3, 2021
Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@tellthemachines tellthemachines merged commit e038551 into trunk Jun 4, 2021
@tellthemachines tellthemachines deleted the fix/hide-widgets-link branch June 4, 2021 00:15
@github-actions github-actions bot added this to the Gutenberg 10.9 milestone Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When themes don't support widgets the editor looks broken
2 participants