Backport fixes for WordPress 5.8 RC4 #33455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add notices container to InterfaceSkeleton. * Move the `EditorSnackbars` component to the notices container.
…33388) Co-authored-by: Andrei Draganescu <github@andreidraganescu.info> Co-authored-by: Robert Anderson <robert@noisysocks.com>
Missing node source will cause an error in the scrollIntoView function and crash the editor.
youknowriad
requested review from
adamziel,
ajitbohra,
cameronvoell,
chrisvanpatten,
draganescu,
ellatrix,
guarani,
kevin940726,
nerrad,
noisysocks,
ntwb,
talldan and
tellthemachines
as code owners
|
Size Change: +359 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
…in functions being loaded. (#33454) * Bootstrap wp-admin before rendering widgets – they may rely on wp-admin functions being loaded. * Bootstrap wp-admin function also in /wp/v2/widgets endpoint * Add a dot at the end of the comment to satisfy linter requirements * Move the require_once statement to encode_form_data to increase the size of the safety net it provides. * Update lib/class-wp-rest-widget-types-controller.php Co-authored-by: Tonya Mork <hello@hellofromtonya.com> Co-authored-by: Tonya Mork <hello@hellofromtonya.com>
youknowriad
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
|
For commit 9d7017f, core's version of if ( rest_is_field_included( 'instance', $fields ) ) {
$widget_object = $wp_widget_factory->get_widget_object( $parsed_id['id_base'] );
if ( $widget_object && isset( $parsed_id['number'] ) ) {
/*
* Third-party widgets may rely on wp-admin functions.
* So let's load them before working with the widget object.
*/
require_once ABSPATH . 'wp-admin/includes/admin.php';
$all_instances = $widget_object->get_settings(); |
…d remove `wordCount` attribute (#33366) * [Block Library - Post Excerpt]: Fix `excerpt_more` filter conflict * use Disabled component * add comments * Remove `wordCount` attribute * prioritize textContent * Post Excerpt: Don't output empty P tag when $more_text empty * Query Loop Patterns: Remove extinct wordCount attribute Co-authored-by: Miguel Fonseca <miguelcsf@gmail.com>
|
@hellofromtonya I'll make sure to ping you on the Core patch if you don't mind ;) |
|
I've removed one change per the discussion in Slack and #33472. |
desrosj
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
excerpt_morefilter conflict and removewordCountattribute #33366