Improve default selection in the Combobox Component #33928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +28 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
sarayourfriend
approved these changes
Aug 6, 2021
|
Hi, @mikejolley Thanks for the fix. This matched behavior described in ARIA 1.1 - https://www.w3.org/TR/wai-aria-practices/examples/combobox/aria1.1pattern/listbox-combo.html#kbd_label_textbox. Can you rebase and force-push the branch? It looks like checks got stuck. |
mikejolley
added a commit
to woocommerce/woocommerce-blocks
that referenced
this pull request
Aug 9, 2021
|
It seems some are still stalling. Any ideas @Mamaduka ? |
mikejolley
added a commit
to woocommerce/woocommerce-blocks
that referenced
this pull request
Aug 12, 2021
|
Maybe do another rebase and force push? I tried but cannot cancel and re-run the "Build Release Artifact" job manually. |
mikejolley
added a commit
to woocommerce/woocommerce-blocks
that referenced
this pull request
Aug 12, 2021
* Add combobox control * Implement in country and state * mobile styling * styling across themes * Remove validated select component * Use focus-within * Update tests * Use @wordpress/compose * Move field clearing to effect hook * Patch combobox component PR WordPress/gutenberg#33928 * patch package after install * update package * Prevent autofill handling impacting manual input * Add todo * combo requires option to be selected
Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com>
|
@Mamaduka I rebased and now there are fails for other things (PHP side). This isn't me :D |
|
It looks like Docker failure; I will restart that one. Not sure what's wrong with the "Build Release Artifact" action, though. |
|
I tried cancelling build release artifact but it says cancelling failed ¯_(ツ)_/¯ |
|
I used admin privileges to squash merge this given there was no way to cancel the errant GH workflow that had no relevance to the changeset in this pr. |
annezazu
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Filtering the results of the Combobox and pressing the enter key leads to an unexpected selection, ignoring your input. This can be reproduced easily in Storybook:
My fix for this is to use a
useEffecthook to update the current selection if the list of suggestions is filtered. If the current selection is no longer available, it's updated to the first match automatically. That means if you do hit enter, you're going to select something more relevant to your input than the original selection.Fixes #33920
How has this been tested?
Tested with this patch on a checkout form using the same steps as above.
Screenshots
This is after the fix. I enter the text and hit enter. My selection is preserved.
Types of changes
This is a bug fix.
Checklist: