Try new icons for reusable blocks and template parts. #34002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Feature] Synced Patterns
|
Size Change: +295 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Aug 11, 2021
mtias
reviewed
Aug 11, 2021
| import { Platform } from '@wordpress/element'; | ||
| import { reusableBlockType } from '@wordpress/icons'; |
There was a problem hiding this comment.
I think maybe we should call this one "symbol" and "symbol-filled" at the icon level
|
Thanks for the fix Nik, thanks for the review! I'll address Matías' comment and land this! |
|
Renamed the icons, and things are looking good. Feel free to press the green button when the checks pass, I have to leave in a little bit.
|
This was referenced Aug 11, 2021
|
Thank you all for the help landing this! 👌 |
|
👋 Im a bit confused on the Icon choice for "Template Part" here. Previously, the icons for template parts and their variations were very coherent and cohesive as a group. Header, Footer, and Sidebar icons are all of the same form with a different area filled in to distinguish them, while the generic "Template Part" icon was the same with no area filled in to distinguish the genericness of the non-variation version. Now, we have one icon for the generic version that has no relation whatsoever to the icons for its variations:
|
In nesting contexts the previous icon was reported as confusing as its design suggested a particular layout that might not be leveraged by that particular generic template part at all. The new icon is intentionally generic as discussed in #33897 so as to clearly denote its special linked nature when shown in the list view. Your comment made me realize a bug, though — the generic icon is meant to also be used for header, footer and sidebar template parts when shown in the list view:
But that doesn't appear to be the case currently:
@ntsekouras can you help me make that happen? |
@jasmussen do you mean to remove the |
|
The latter, show the generic icon in toolbar, block card and list views. The icons still feel useful in cases like the area selector dropdown that's being proposed in #29295:
|
|
@ntsekouras just to make sure #34002 (comment) doesn't fall off the radar, should I open a separate ticket for it? I'd be happy to pair on it. |
|
I went ahead and ticketed it in #35453. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starts work on #33897 by adding new generic icons for template parts and reusable blocks.
For now, the PR adds the two new icons, and applies them to template parts and partially, reusable blocks:
As shown above, there's still some logic in the Reusable Block system that falls back to the
defaultBlockicon, as shown above:Additionally, the
defaultBlockis used for select mode:If you're familiar with the reusable blocks codebase, I'd appreciate your help in applying the new icon in those remaining place.
How has this been tested?
Template Parts and Reusable blocks, when used in the canvas, list view, and inspector, should leverage the new icons.
Checklist:
*.native.jsfiles for terms that need renaming or removal).