Legacy widget's preview functionality is broken when the page is moved#34384

Merged

kevin940726 merged 23 commits intoWordPress:trunkfrom anton-vlasenko:fix/use-rest-api-endpoint-for-legacy-widget-preview

Aug 31, 2021

+74-49

Commits on Aug 30, 2021

Load preview using the new REST API endpoint.
anton-vlasenko
committed
1. Use previewLoaded instead of srcdoc attribute to check if the preview was loaded.
anton-vlasenko
committed
1. Rename renderPreview function (code review feedback).
anton-vlasenko
committed
Fix bug related to isPreviewFetched state.
anton-vlasenko
committed
Don't call fetchPreviewHTML with arguments because we use closures now.
anton-vlasenko
committed
useEffect should always return a cleanup function.
anton-vlasenko
committed
Don't call useEffect on each component rerender.
anton-vlasenko
committed
1. Use an optional chaining operator instead of typeof to improve readability.
anton-vlasenko
committed
1. Don't use a custom message as it increases the bundle size and the error message can't be minified.
anton-vlasenko
committed
An attempt to fix the failing test.
anton-vlasenko
committed
2nd attempt to fix the failing test.
anton-vlasenko
committed
3rd attempt to fix the failing test.
anton-vlasenko
committed
4rd attempt to fix the failing test.
anton-vlasenko
committed
5th attempt to fix the failing test.
anton-vlasenko
committed
A small change to trigger CI checks.
anton-vlasenko
committed
Remove irrelevant comment.
anton-vlasenko
committed
Change REST API endpoint url because it was changed in #34230
anton-vlasenko
committed
1. Fix parameter names (we should use id and instance parameters).
anton-vlasenko
committed
1. Fix parameter names (we should use id and instance parameters).
anton-vlasenko
committed
1. Revert endpoint and use /render again (because it was changed in the original PR).
anton-vlasenko
committed
Fix request parameters.
anton-vlasenko
committed
Get rid of the id_base parameter.
anton-vlasenko
committed
Don't send request parameters if the instance is empty.
anton-vlasenko
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Legacy widget's preview functionality is broken when the page is moved#34384

Commits on Aug 30, 2021

Load preview using the new REST API endpoint.

1. Use previewLoaded instead of srcdoc attribute to check if the preview was loaded.

1. Rename renderPreview function (code review feedback).

Fix bug related to isPreviewFetched state.

Don't call fetchPreviewHTML with arguments because we use closures now.

useEffect should always return a cleanup function.

Don't call useEffect on each component rerender.

1. Use an optional chaining operator instead of typeof to improve readability.

1. Don't use a custom message as it increases the bundle size and the error message can't be minified.

An attempt to fix the failing test.

2nd attempt to fix the failing test.

3rd attempt to fix the failing test.

4rd attempt to fix the failing test.

5th attempt to fix the failing test.

A small change to trigger CI checks.

Remove irrelevant comment.

Change REST API endpoint url because it was changed in #34230

1. Fix parameter names (we should use id and instance parameters).

1. Fix parameter names (we should use id and instance parameters).

1. Revert endpoint and use /render again (because it was changed in the original PR).

Fix request parameters.

Get rid of the id_base parameter.

Don't send request parameters if the instance is empty.