Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/3450: Events passed to onChange erroneously triggered shouldForce #3487

Merged
merged 1 commit into from
Nov 15, 2017

Conversation

BoardJames
Copy link

Description

This is a fix for #3450 which caused too many undo events to be created.

How Has This Been Tested?

Manual testing on Firefox and Chrome shows that the undo buttons work again with this fix.

Types of changes

Bug fix.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@BoardJames BoardJames added the [Type] Bug An existing feature does not function as intended label Nov 15, 2017
@BoardJames BoardJames self-assigned this Nov 15, 2017
@codecov
Copy link

codecov bot commented Nov 15, 2017

Codecov Report

Merging #3487 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3487   +/-   ##
=======================================
  Coverage   34.64%   34.64%           
=======================================
  Files         260      260           
  Lines        6737     6737           
  Branches     1219     1219           
=======================================
  Hits         2334     2334           
  Misses       3717     3717           
  Partials      686      686
Impacted Files Coverage Δ
blocks/editable/index.js 10.79% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceb4e69...b5568ae. Read the comment docs.

@BoardJames BoardJames merged commit 74d8ab9 into master Nov 15, 2017
@BoardJames BoardJames deleted the fix/3450-onChange-forced-erroneously branch November 15, 2017 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants