Fixed quote<->list transformations #3525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
force-pushed
the
fix/fixed-quote-list-transformations
branch
3 times, most recently
from
e2d62fc to
14392b2
Compare
gziolo
requested changes
Nov 17, 2017
jorgefilipecosta
force-pushed
the
fix/fixed-quote-list-transformations
branch
from
14392b2 to
8d8f484
Compare
Codecov Report
@@ Coverage Diff @@
## master #3525 +/- ##
=========================================
+ Coverage 34.85% 35.8% +0.95%
=========================================
Files 261 262 +1
Lines 6717 6862 +145
Branches 1225 1274 +49
=========================================
+ Hits 2341 2457 +116
- Misses 3691 3716 +25
- Partials 685 689 +4
Continue to review full report at Codecov.
|
jorgefilipecosta
force-pushed
the
fix/fixed-quote-list-transformations
branch
from
8d8f484 to
f6f7a49
Compare
jorgefilipecosta
force-pushed
the
fix/fixed-quote-list-transformations
branch
from
f6f7a49 to
3bf5a17
Compare
gziolo
reviewed
Nov 17, 2017
| value: [ <p key="list">{ toBrDelimitedContent( values ) }</p> ], | ||
| value: ( values.length === 1 ? values : initial( values ) ) | ||
| .map( ( value ) => ( { children: <p> { get( value, 'props.children' ) } </p> } ) ), | ||
| citation: ( values.length === 1 ? undefined : get( last( values ), 'props.children' ) ), |
gziolo
approved these changes
Nov 17, 2017
|
It works perfectly fine now. 🙇 |
|
Thank you for your review @gziolo. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix a bug that I just discovered. Transforming from a quote into a list throws an error, and transforming a list into a quote creates a quote with empty content.
This PR solves both problems and simplifies the logic in a similar way of what was done in paragraph<->list transformations.
Now, transforming from quote to list, creates a list of the quote paragraphs and the last item being the citation. Transforming a list into a quote creates a paragraph for each list item excluding the last one that is used as a citation. This makes the transformations (quote->list->quote, list->quote->list)
totally idempotent.
How Has This Been Tested?
Transform a quote (empty and non-empty) into a list. Verify the first two values of the list are quote, citation.
Transform a list (empty and non-empty) into a quote. Verify the first two values of the list are now quote and citation of the quote block. If the list contains more than two values just the first two should be used.
Screenshots (jpeg or gifs if applicable):
Before:
List to quote
Quote to list
After: