List View: windowing try rendering placeholders instead of padding #35571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +918 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
Placeholders Run 1:This is actually a pretty interesting result. We see similar performance characteristics to rendering a much smaller number of rows, which suggests there are some severe slowdowns rendering list view blocks. (Perhaps icons or slow selectors?) I'm curious, so I'll do two follow up things here:
Placeholders Run two with 4x post sizeWindowing Run with x4 Post size |
gwwar
force-pushed
the
try/list-view-placeholder
branch
from
f8f71a1 to
25db3e6
Compare
So I profiled a bit on trunk. This is pretty informal but roughly measured that focus time scales with the number of blocks but is exacerbated by the list view being open. If we render arbitrary content in rows instead of Focusing on a block in the editor re-renders all list-view items.
|
gwwar
force-pushed
the
try/list-view-placeholder
branch
from
f891610 to
25db3e6
Compare
|
This was a good exercise, I'll close this one out for now and report findings on the main PR. |
5 tasks
…overscan default to visible items
gwwar
force-pushed
the
try/list-view-placeholder
branch
from
2f21c9a to
c6b08e5
Compare
|
Edit: comparing a second run has similar results, so rendering row placeholders has about a 100ms cost here on the 900 block performance post. Placeholderpadding |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was recommended by @talldan to see if we could use placeholders after reviewing #35230. This is a quick sketch to see if there's any performance impact with windowing if we render a fixed number of items in a list vs all items, but using simple placeholder items for items outside of the current window.
Another point of consideration is that this is likely to block framer dragging #34022 I didn't have great results when I tried turning off the layout checks for only some items in that branch.
CleanShot.2021-10-12.at.15.01.30.mp4