Adds in basic styling for post comment form #35704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +4.35 kB (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
jffng
reviewed
Oct 18, 2021
There was a problem hiding this comment.
What do you think about adding padding to the text inputs, and allowing the textarea to inherit the font family from the body?
Using Twenty Twenty-Two as an example:
| Before | After |
|---|---|
 |
 |
I think the cookie consent text could also be smaller by default, but that's less important to me than the padding and font family on the comment textarea.
|
It would be good if the padding matched other input fields. The search block fields has |
|
@karmatosed I hope you don't mind, I pushed a few small updates.
Here's how those look now:
|
|
Here's how the updates look in TT1 Blocks too. There's some slightly unfortunate text wrapping next to the checkbox down below. Maybe we should style that too?
|
|
I tidied up that cookies consent area. In general it's looking ok. I'm unclear if this is useful in the context of #35231 though? Anyway, here's how this PR currently looks in various themes: Twenty Twenty-Two:
TT1 Blocks:
Twenty Twenty-One:
Twenty Twenty:
|
|
A few thoughts:
|
jffng
reviewed
Oct 21, 2021
| overflow-wrap: break-word; | ||
| } | ||
|
|
||
| textarea, |
There was a problem hiding this comment.
What if we let the font-family: inherit; for this textarea?
There was a problem hiding this comment.
Whoops — I missed that originally. Should be all set as of 4881e18.
I think it is still useful, I don't think the form is going to be split yet. |
|
That spacing in Twenty Twenty though 🤐 |
carolinan
approved these changes
Oct 22, 2021
|
Thanks, everyone! |
@kjellr I absolutely don't mind at all and love this thank you. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reworked version of stale PR #27009 which I closed today.
@kjellr and @jffng looping you in as know tracking this for Twenty Twenty Two.
@colorful-tones I removed all the review points you noted to reduce back as much as I can on styling.
Whilst I do think more styling could be done by default, I have concerns setting any font sizes or anything else at this point, so I really went as minimal as possible. I am open to other options being brought in though as it looks 'simple' to say the least.