-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fallback handling for plugins or themes using the Customizer #35877
Add fallback handling for plugins or themes using the Customizer #35877
Conversation
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Clorith! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
I am still curious why the removal of the menu item simply can't be reverted. |
Adding a quick note that my patch here implements a new function, As for the discussion about whether something should be reverted or not, I'll leave that for the product team to tackle, my main concern with this PR was to ensure backwards compatibility and nothing more :) |
Thanks for working on this! I think we should strive to implement this PR as the solution to #35874. If possible I'd prefer to not always show a link to the Customizer as I feel it will be confusing to users who are brand new to WordPress to have both an Appearance → Editor and Appearance → Customize. We may end up having to always show a link to the Customizer. For example, if we don't end up with a solution for #29126 in time for WP 5.9 then we don't really have a choice. We can make this decision in the 5.9 beta period if need be. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @Clorith, can you rebase this branch on top of the current trunk
and I think we're good to merge once all checks are green ✅
Sorry @Clorith, looks like there are more conflicts. Could you please rebase again? Feel free to merge once resolved. |
Description
This change introduces a new function,
gutenberg_site_requires_customizer()
, which looks up if any plugins, or theme features, have added support for the Customizer.It then utilizes that check before letting Full Site Editing filter away the Customizer access points. It is worth noting that the Customizer is not deactivated even without this patch, but it is important to maintain a canonical entry-point for the user when any plugin, or theme feature, relies on it.
This would fix #35874
How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: