Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add brief information about blockGap to the theme.json how-to guide #36558

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Add brief information about blockGap to the theme.json how-to guide #36558

merged 1 commit into from
Nov 23, 2021

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Nov 17, 2021 •
edited
Loading

Description

Adds information about blockGap to the Global Settings & Styles (theme.json) handbook page.

Closes #35488.

Types of changes

Documentation

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@carolinan carolinan requested a review from ajitbohra as a code owner November 17, 2021 08:31
@carolinan carolinan added the [Type] Developer Documentation Documentation for developers label Nov 17, 2021
mkaz
mkaz approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this, quite helpful! 👍

@mkaz mkaz merged commit 85a6b87 into trunk Nov 23, 2021
@mkaz mkaz deleted the update/doc-theme-json-blockgap branch November 23, 2021 16:45
@github-actions github-actions bot added this to the Gutenberg 12.1 milestone Nov 23, 2021
@carolinan carolinan mentioned this pull request Nov 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaz mkaz mkaz approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 12.1
Development

Successfully merging this pull request may close these issues.

Add documentation for blockGap
2 participants
@carolinan @mkaz