Post Featured Image: Add the "Reset" button #36572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Block] Post Featured Image
|
@jameskoster I'm not 100% sure about the "Bug" label. Should we use the "Enhancement" label instead? What do you think? |
|
Size Change: +25 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
7 tasks
|
I'm not seeing a replace option in the site editor 🤔 Works fine in the post editor though. |
|
@jameskoster I think that's because some blocks inside Query Loop aren't editable. Ref: #32505. |
|
A yes, that makes sense. |
jameskoster
approved these changes
Nov 17, 2021
Mamaduka
force-pushed
the
add/featured-image-reset-button
branch
from
3a1458b to
afe4641
Compare
|
@jameskoster I'm going to merge this PR. The code change is pretty small, and I'm confident it won't break things 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the "Reset" button to media replace controls.
Fixes #36566.
How has this been tested?
Screenshots
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).