Navigation block: Use inherit and a parent for navigation posts. #37302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacedmonkey
requested review from
adamziel,
getdave,
talldan,
TimothyBJacobs,
tellthemachines and
anton-vlasenko
This comment has been minimized.
This comment has been minimized.
|
Size Change: +240 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
👋🏻 |
|
@draganescu Never mind that feedback. |
|
Would this mean a navigation menu can only be used in a single template part? |
38 tasks
getdave
reviewed
Dec 14, 2021
There was a problem hiding this comment.
Firstly thank you for exploring this so quickly.
Based on your conversation with @TimothyBJacobs, it seems the approach may need further discussion.
I tried testing and found that this doesn't appear to fully solve #36286. Specifically the Nav items aren't saved - still get 403 cannot publish - and thus disappear when you refresh.
Screen.Capture.on.2021-12-14.at.09-53-49.mp4
It would be really helpful to contributors not privy to Slack discussion if there were specific test instructions here. I appreciate there's an outline of instructions in the Issue but this PR deals with very specific permissions testing and I think having test instructions listed would help to get sufficient traction with reviewers.
Let's continue exploring this route alongside our other options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on a discussion found here.
In short, force all navigation posts to have a parent and status inherit. Meaning that permission are inherited from the original fix. This fixes #36286 and also handles the case of none public / private post with embedded navigations.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).