Fix flaky test by using waitForResponse to ensure the url details request completes #37901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uest completes and 404s
talldan
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
|
I'll give this a few re-runs, but fingers crossed it works 🤞 |
12 tasks
talldan
force-pushed
the
fix/flaky-navigation-draft-creation-test
branch
from
d0c893f to
bcc03c8
Compare
talldan
force-pushed
the
fix/flaky-navigation-draft-creation-test
branch
from
af0b3a7 to
881f588
Compare
|
Spotted some other issues with the test. I'd misunderstood the way the test works, thinking That would explain why the test wasn't working before, it was waiting for the network request in the wrong place! 🤦 Hopefully now it should be working as expected 🤞 |
|
Passed 5 times, so hopefully that means it's solved. |
getdave
approved these changes
Jan 12, 2022
Mamaduka
approved these changes
Jan 12, 2022
|
@talldan, do you think a similar check can be used to fix this test as well - https://github.com/WordPress/gutenberg/runs/4785599397?check_suite_focus=true. I've seen it fail on the trunk a dozen times in the last couple of weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alternative to #37755, Fixes #37479
My previous attempt to make this test more robust used the
waitForNetworkIdlefunction to ensure the url-details request completed so that the test can handle the 404 it returns. But that didn't seem to work consistently and the test was reported as flaky.Looking at the docs, I discovered puppeteer has a
waitForResponsefunction that should improve the situation.