From 11bfdd1dd85449b4b85e88dd84ae9b7a049ad32e Mon Sep 17 00:00:00 2001 From: Matthew Kevins Date: Fri, 7 Jan 2022 14:16:53 +1000 Subject: [PATCH 01/10] Release script: Update react-native-editor version to 1.69.0 --- packages/react-native-aztec/package.json | 2 +- packages/react-native-bridge/package.json | 2 +- packages/react-native-editor/package.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/react-native-aztec/package.json b/packages/react-native-aztec/package.json index 8dca9b07b2da4a..49b7783b15a6c0 100644 --- a/packages/react-native-aztec/package.json +++ b/packages/react-native-aztec/package.json @@ -1,6 +1,6 @@ { "name": "@wordpress/react-native-aztec", - "version": "1.68.0", + "version": "1.69.0", "description": "Aztec view for react-native.", "private": true, "author": "The WordPress Contributors", diff --git a/packages/react-native-bridge/package.json b/packages/react-native-bridge/package.json index d04b27e4a8903a..e0dafbfd6a4faf 100644 --- a/packages/react-native-bridge/package.json +++ b/packages/react-native-bridge/package.json @@ -1,6 +1,6 @@ { "name": "@wordpress/react-native-bridge", - "version": "1.68.0", + "version": "1.69.0", "description": "Native bridge library used to integrate the block editor into a native App.", "private": true, "author": "The WordPress Contributors", diff --git a/packages/react-native-editor/package.json b/packages/react-native-editor/package.json index 4db2f36958ee17..7b521633996df8 100644 --- a/packages/react-native-editor/package.json +++ b/packages/react-native-editor/package.json @@ -1,6 +1,6 @@ { "name": "@wordpress/react-native-editor", - "version": "1.68.0", + "version": "1.69.0", "description": "Mobile WordPress gutenberg editor.", "author": "The WordPress Contributors", "license": "GPL-2.0-or-later", From dbd8854419e76e9d0fc37be00bc561307a70ba70 Mon Sep 17 00:00:00 2001 From: Matthew Kevins Date: Fri, 7 Jan 2022 14:21:33 +1000 Subject: [PATCH 02/10] Release script: Update with changes from 'npm run core preios' --- packages/react-native-editor/ios/Podfile.lock | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/react-native-editor/ios/Podfile.lock b/packages/react-native-editor/ios/Podfile.lock index bf06bd90b2ee18..78a92ecaf423d4 100644 --- a/packages/react-native-editor/ios/Podfile.lock +++ b/packages/react-native-editor/ios/Podfile.lock @@ -13,7 +13,7 @@ PODS: - ReactCommon/turbomodule/core (= 0.66.2) - fmt (6.2.1) - glog (0.3.5) - - Gutenberg (1.68.0): + - Gutenberg (1.69.0): - React-Core (= 0.66.2) - React-CoreModules (= 0.66.2) - React-RCTImage (= 0.66.2) @@ -312,7 +312,7 @@ PODS: - React-Core - RNSVG (9.13.7-wp-2): - React-Core - - RNTAztecView (1.68.0): + - RNTAztecView (1.69.0): - React-Core - WordPress-Aztec-iOS (~> 1.19.7) - WordPress-Aztec-iOS (1.19.7) @@ -478,7 +478,7 @@ SPEC CHECKSUMS: FBReactNativeSpec: 18438b1c04ce502ed681cd19db3f4508964c082a fmt: ff9d55029c625d3757ed641535fd4a75fedc7ce9 glog: 5337263514dd6f09803962437687240c5dc39aa4 - Gutenberg: 5db4fee03946ebc20f35a38f99cab2c42a8d753d + Gutenberg: aa24b9f5cc3c8893b7c8eac029ebb8c6ffcfcfe6 RCT-Folly: a21c126816d8025b547704b777a2ba552f3d9fa9 RCTRequired: 5e9e85f48da8dd447f5834ce14c6799ea8c7f41a RCTTypeSafety: aba333d04d88d1f954e93666a08d7ae57a87ab30 @@ -517,7 +517,7 @@ SPEC CHECKSUMS: RNReanimated: 7d8459391b2f3e1dc6dea919307db4adf4c1d254 RNScreens: ec0e85d1babdd61d7ec78c98072d9e6b62d96ff6 RNSVG: b3b9c40381636e5116894398d72a830be15b7258 - RNTAztecView: e502408a3c3cb98f513346a179febb91bcd3e528 + RNTAztecView: e291f5ff7161f1640b15bce2907e9cd89e17fbf9 WordPress-Aztec-iOS: 144f124148079084860368dfd27cb96e0952853e Yoga: 9a08effa851c1d8cc1647691895540bc168ea65f From 08030ebedf51d9e8f2a5ec982970f7baf75f120f Mon Sep 17 00:00:00 2001 From: Matthew Kevins Date: Fri, 7 Jan 2022 15:50:48 +1000 Subject: [PATCH 03/10] Update native editor changelog for v1.69.0 --- packages/react-native-editor/CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/react-native-editor/CHANGELOG.md b/packages/react-native-editor/CHANGELOG.md index 6b3f3a1a048805..71befc0d1c0e18 100644 --- a/packages/react-native-editor/CHANGELOG.md +++ b/packages/react-native-editor/CHANGELOG.md @@ -10,6 +10,8 @@ For each user feature we should also add a importance categorization label to i --> ## Unreleased + +## 1.69.0 - [*] Give multi-line block names central alignment in inserter [#37185] - [**] Fix empty line apperaing when splitting heading blocks on Android 12 [#37279] - [**] Fix missing translations by refactoring the editor initialization code [#37073] From c73e040ddbbc51de43d12468b786b23791273142 Mon Sep 17 00:00:00 2001 From: Matthew Kevins Date: Mon, 17 Jan 2022 17:24:31 +1000 Subject: [PATCH 04/10] Release script: Update react-native-editor version to 1.69.1 --- packages/react-native-aztec/package.json | 2 +- packages/react-native-bridge/package.json | 2 +- packages/react-native-editor/package.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/react-native-aztec/package.json b/packages/react-native-aztec/package.json index 49b7783b15a6c0..8b43159c918a2e 100644 --- a/packages/react-native-aztec/package.json +++ b/packages/react-native-aztec/package.json @@ -1,6 +1,6 @@ { "name": "@wordpress/react-native-aztec", - "version": "1.69.0", + "version": "1.69.1", "description": "Aztec view for react-native.", "private": true, "author": "The WordPress Contributors", diff --git a/packages/react-native-bridge/package.json b/packages/react-native-bridge/package.json index e0dafbfd6a4faf..c407a020d61053 100644 --- a/packages/react-native-bridge/package.json +++ b/packages/react-native-bridge/package.json @@ -1,6 +1,6 @@ { "name": "@wordpress/react-native-bridge", - "version": "1.69.0", + "version": "1.69.1", "description": "Native bridge library used to integrate the block editor into a native App.", "private": true, "author": "The WordPress Contributors", diff --git a/packages/react-native-editor/package.json b/packages/react-native-editor/package.json index 7b521633996df8..ee7b80b603f33c 100644 --- a/packages/react-native-editor/package.json +++ b/packages/react-native-editor/package.json @@ -1,6 +1,6 @@ { "name": "@wordpress/react-native-editor", - "version": "1.69.0", + "version": "1.69.1", "description": "Mobile WordPress gutenberg editor.", "author": "The WordPress Contributors", "license": "GPL-2.0-or-later", From 1b70c1c2dbab23e984217df4375a338c8f1d5104 Mon Sep 17 00:00:00 2001 From: Matthew Kevins Date: Mon, 17 Jan 2022 17:25:12 +1000 Subject: [PATCH 05/10] Release script: Update with changes from 'npm run core preios' --- packages/react-native-editor/ios/Podfile.lock | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/react-native-editor/ios/Podfile.lock b/packages/react-native-editor/ios/Podfile.lock index 78a92ecaf423d4..9df4de12adc6a7 100644 --- a/packages/react-native-editor/ios/Podfile.lock +++ b/packages/react-native-editor/ios/Podfile.lock @@ -13,7 +13,7 @@ PODS: - ReactCommon/turbomodule/core (= 0.66.2) - fmt (6.2.1) - glog (0.3.5) - - Gutenberg (1.69.0): + - Gutenberg (1.69.1): - React-Core (= 0.66.2) - React-CoreModules (= 0.66.2) - React-RCTImage (= 0.66.2) @@ -312,7 +312,7 @@ PODS: - React-Core - RNSVG (9.13.7-wp-2): - React-Core - - RNTAztecView (1.69.0): + - RNTAztecView (1.69.1): - React-Core - WordPress-Aztec-iOS (~> 1.19.7) - WordPress-Aztec-iOS (1.19.7) @@ -478,7 +478,7 @@ SPEC CHECKSUMS: FBReactNativeSpec: 18438b1c04ce502ed681cd19db3f4508964c082a fmt: ff9d55029c625d3757ed641535fd4a75fedc7ce9 glog: 5337263514dd6f09803962437687240c5dc39aa4 - Gutenberg: aa24b9f5cc3c8893b7c8eac029ebb8c6ffcfcfe6 + Gutenberg: d69d85336bf2686d7947bea8addf3643880beb23 RCT-Folly: a21c126816d8025b547704b777a2ba552f3d9fa9 RCTRequired: 5e9e85f48da8dd447f5834ce14c6799ea8c7f41a RCTTypeSafety: aba333d04d88d1f954e93666a08d7ae57a87ab30 @@ -517,7 +517,7 @@ SPEC CHECKSUMS: RNReanimated: 7d8459391b2f3e1dc6dea919307db4adf4c1d254 RNScreens: ec0e85d1babdd61d7ec78c98072d9e6b62d96ff6 RNSVG: b3b9c40381636e5116894398d72a830be15b7258 - RNTAztecView: e291f5ff7161f1640b15bce2907e9cd89e17fbf9 + RNTAztecView: e9f061b6629b3353e19a304ebcebd91d1f0924cc WordPress-Aztec-iOS: 144f124148079084860368dfd27cb96e0952853e Yoga: 9a08effa851c1d8cc1647691895540bc168ea65f From 9658d2d7a805181ebb5b01e6511c3637f38e8804 Mon Sep 17 00:00:00 2001 From: Gerardo Pacheco Date: Wed, 12 Jan 2022 12:39:38 +0100 Subject: [PATCH 06/10] Mobile - Gallery block - Fix issue migrating old format and missing fixedHeight context, use of images prop instead of the attributes (#37889) --- packages/block-library/src/gallery/deprecated.js | 4 ++++ packages/block-library/src/gallery/gallery.native.js | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/block-library/src/gallery/deprecated.js b/packages/block-library/src/gallery/deprecated.js index 001bbba8ea8366..3668ed74db4f10 100644 --- a/packages/block-library/src/gallery/deprecated.js +++ b/packages/block-library/src/gallery/deprecated.js @@ -195,6 +195,10 @@ const v6 = { type: 'boolean', default: true, }, + fixedHeight: { + type: 'boolean', + default: true, + }, linkTo: { type: 'string', }, diff --git a/packages/block-library/src/gallery/gallery.native.js b/packages/block-library/src/gallery/gallery.native.js index ccdf86f3ea3728..d8760918f1edf3 100644 --- a/packages/block-library/src/gallery/gallery.native.js +++ b/packages/block-library/src/gallery/gallery.native.js @@ -35,6 +35,7 @@ export const Gallery = ( props ) => { const { mediaPlaceholder, attributes, + images, isNarrow, onBlur, insertBlocksAfter, @@ -49,7 +50,6 @@ export const Gallery = ( props ) => { }, [ sizes ] ); const { - images, align, columns = defaultColumnsNumber( images.length ), } = attributes; From 4d084001a1dc31cfc0afa97793be2135666a4c3d Mon Sep 17 00:00:00 2001 From: Gerardo Pacheco Date: Fri, 14 Jan 2022 15:06:58 +0100 Subject: [PATCH 07/10] [Mobile] - RichText - Use parsed font size values when comparing new changes (#37951) * Mobile - RichText - Use parsed font size values when comparing new changes to avoid not matching values that generate a render loop * Mobile - E2E - Move typography test to full tests instead of canary * Mobile - RichText - Avoid using the fontSize value from the props if there's a font size set from the styles * Mobile - E2E - Remove test and move some test cases into the current integration tests * Mobile - RichTest - Update tests --- .../rich-text/src/component/index.native.js | 42 ++++++++-- .../test/__snapshots__/index.native.js.snap | 65 +++++++++++++++ packages/rich-text/src/test/index.native.js | 83 +++++++++++++++---- 3 files changed, 166 insertions(+), 24 deletions(-) create mode 100644 packages/rich-text/src/test/__snapshots__/index.native.js.snap diff --git a/packages/rich-text/src/component/index.native.js b/packages/rich-text/src/component/index.native.js index 8eba7874e1f36a..7d6a2d490e6b5c 100644 --- a/packages/rich-text/src/component/index.native.js +++ b/packages/rich-text/src/component/index.native.js @@ -836,8 +836,14 @@ export class RichText extends Component { this._editor.blur(); } - const currentFontSizeStyle = parseFloat( style?.fontSize ); - const prevFontSizeStyle = parseFloat( prevProps?.style?.fontSize ); + // For font size values changes from the font size picker + // we compare previous values to refresh the selected font size, + // this is also used when the tag name changes + // e.g Heading block and a level change like h1->h2. + const currentFontSizeStyle = this.getParsedFontSize( style?.fontSize ); + const prevFontSizeStyle = this.getParsedFontSize( + prevProps?.style?.fontSize + ); const isDifferentTag = prevProps.tagName !== tagName; if ( ( currentFontSize && @@ -891,6 +897,20 @@ export class RichText extends Component { }; } + getParsedFontSize( fontSize ) { + const { height, width } = Dimensions.get( 'window' ); + const cssUnitOptions = { height, width, fontSize: DEFAULT_FONT_SIZE }; + + if ( ! fontSize ) { + return fontSize; + } + + const selectedPxValue = + getPxFromCssUnit( fontSize, cssUnitOptions ) ?? DEFAULT_FONT_SIZE; + + return parseFloat( selectedPxValue ); + } + getFontSize( props ) { const { baseGlobalStyles, tagName, fontSize, style } = props; const tagNameFontSize = @@ -898,30 +918,34 @@ export class RichText extends Component { let newFontSize = DEFAULT_FONT_SIZE; + // For block-based themes, get the default editor font size. if ( baseGlobalStyles?.typography?.fontSize ) { newFontSize = baseGlobalStyles?.typography?.fontSize; } + // For block-based themes, get the default element font size + // e.g h1, h2. if ( tagNameFontSize ) { newFontSize = tagNameFontSize; } + // For font size values provided from the styles, + // usually from values set from the font size picker. if ( style?.fontSize ) { newFontSize = style.fontSize; } - if ( fontSize && ! tagNameFontSize ) { + // Fall-back to a font size provided from its props (if there's any) + // and there are no other default values to use. + if ( fontSize && ! tagNameFontSize && ! style?.fontSize ) { newFontSize = fontSize; } - const { height, width } = Dimensions.get( 'window' ); - const cssUnitOptions = { height, width, fontSize: DEFAULT_FONT_SIZE }; + // We need to always convert to px units because the selected value // could be coming from the web where it could be stored as a different unit. - const selectedPxValue = - getPxFromCssUnit( newFontSize, cssUnitOptions ) ?? - DEFAULT_FONT_SIZE; + const selectedPxValue = this.getParsedFontSize( newFontSize ); - return parseFloat( selectedPxValue ); + return selectedPxValue; } getLineHeight() { diff --git a/packages/rich-text/src/test/__snapshots__/index.native.js.snap b/packages/rich-text/src/test/__snapshots__/index.native.js.snap new file mode 100644 index 00000000000000..49c9a7dad92da9 --- /dev/null +++ b/packages/rich-text/src/test/__snapshots__/index.native.js.snap @@ -0,0 +1,65 @@ +// Jest Snapshot v1, https://goo.gl/fbAQLP + +exports[` Font Size renders component with style and font size 1`] = ` +" +

Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed imperdiet ut nibh vitae ornare. Sed auctor nec augue at blandit.

+" +`; + +exports[` Font Size should update the font size when style prop with font size property is provided 1`] = ` + + + +`; + +exports[` Font Size should update the font size with decimals when style prop with font size property is provided 1`] = ` + + + +`; diff --git a/packages/rich-text/src/test/index.native.js b/packages/rich-text/src/test/index.native.js index b48d8828326494..f91e2e18b4bc01 100644 --- a/packages/rich-text/src/test/index.native.js +++ b/packages/rich-text/src/test/index.native.js @@ -1,16 +1,26 @@ -jest.mock( '@wordpress/data/src/components/use-select' ); /** * External dependencies */ import { Dimensions } from 'react-native'; -import { render } from 'test/helpers'; +import { getEditorHtml, render, initializeEditor } from 'test/helpers'; + /** * WordPress dependencies */ -import { useSelect } from '@wordpress/data'; +import { select } from '@wordpress/data'; +import { store as blockEditorStore } from '@wordpress/block-editor'; +import { coreBlocks, registerBlock } from '@wordpress/block-library'; +import { + getBlockTypes, + setDefaultBlockName, + unregisterBlockType, +} from '@wordpress/blocks'; +import '@wordpress/jest-console'; + /** * Internal dependencies */ +import { store as richTextStore } from '../store'; import RichText from '../component/index.native'; /** @@ -25,16 +35,12 @@ const mockGlobalSettings = ( const DEFAULT_GLOBAL_STYLES = { __experimentalGlobalStylesBaseStyles: { typography: { fontSize } }, }; - const selectMock = { - getFormatTypes: jest.fn().mockReturnValue( [] ), - getBlockParents: jest.fn(), - getBlock: jest.fn(), - getSettings: jest.fn().mockReturnValue( DEFAULT_GLOBAL_STYLES ), - }; - - useSelect.mockImplementation( ( callback ) => { - return callback( () => selectMock ); - } ); + jest.spyOn( select( blockEditorStore ), 'getSettings' ).mockReturnValue( + DEFAULT_GLOBAL_STYLES + ); + jest.spyOn( select( richTextStore ), 'getFormatTypes' ).mockReturnValue( + [] + ); }; describe( '', () => { @@ -51,6 +57,13 @@ describe( '', () => { [ '1.42vh', 19 ], ]; + beforeAll( () => { + // Register Paragraph block + const paragraph = coreBlocks[ 'core/paragraph' ]; + registerBlock( paragraph ); + setDefaultBlockName( paragraph.name ); + } ); + beforeEach( () => { mockGlobalSettings( {} ); } ); @@ -59,6 +72,13 @@ describe( '', () => { Dimensions.set( { window } ); } ); + afterAll( () => { + // Clean up registered blocks + getBlockTypes().forEach( ( block ) => { + unregisterBlockType( block.name ); + } ); + } ); + describe( 'Font Size', () => { it( 'should display rich text at the DEFAULT font size.', () => { // Arrange @@ -133,10 +153,10 @@ describe( '', () => { } ); - it( `should display rich text at the font size computed from the LOCAL \`fontSize\` CSS with HIGHEST PRIORITY + it( `should display rich text at the font size computed from the LOCAL \`style.fontSize\` CSS with HIGHEST PRIORITY when CSS is provided ambiguously from ALL possible sources.`, () => { // Arrange - const expectedFontSize = 2; + const expectedFontSize = 1; mockGlobalSettings( { fontSize: '0' } ); // Act const { getByA11yLabel } = render( @@ -193,5 +213,38 @@ describe( '', () => { const actualFontSize = getByA11yLabel( 'editor' ).props.fontSize; expect( actualFontSize ).toBe( expectedFontSize ); } ); + + it( 'should update the font size when style prop with font size property is provided', () => { + // Arrange + const fontSize = '10'; + const style = { fontSize: '12' }; + // Act + const screen = render( ); + screen.update( ); + // Assert + expect( screen.toJSON() ).toMatchSnapshot(); + } ); + + it( 'renders component with style and font size', async () => { + // Arrange + const initialHtml = ` +

Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed imperdiet ut nibh vitae ornare. Sed auctor nec augue at blandit.

+ `; + // Act + await initializeEditor( { initialHtml } ); + // Assert + expect( getEditorHtml() ).toMatchSnapshot(); + } ); + + it( 'should update the font size with decimals when style prop with font size property is provided', () => { + // Arrange + const fontSize = '10'; + const style = { fontSize: '12.56px' }; + // Act + const screen = render( ); + screen.update( ); + // Assert + expect( screen.toJSON() ).toMatchSnapshot(); + } ); } ); } ); From 98dad3bb53f86318c7e71f5bf1abbff94a02cdb0 Mon Sep 17 00:00:00 2001 From: David Calhoun <438664+dcalhoun@users.noreply.github.com> Date: Fri, 7 Jan 2022 13:32:25 -0600 Subject: [PATCH 08/10] Fix LinkPicker freeze when virtual keyboard is hidden (#37782) * Fix LinkPicker freeze when virtual keyboard is hidden When a devices virtual keyboard is hidden, e.g. when a hardware keyboard is connected, dismissing the `LinkPicker` resulted in the application freezing. The freeze likely originates from an unconsumed `LayoutAnimation` registered during resizing of the `BottomSheet`. To address this issue, we now avoid registering a `LayoutAnimation` whenever the changes to the header are sub-pixel values, which can result in the `LayoutAnimation` going unconsumed. https://git.io/J9q2G Long-term, we should likely consider refactoring the `BottomSheet` to holistically avoid stacking `LayoutAnimations`: https://git.io/J9q2l * Support unique BottomSheet header testID This allows individual tests to pass a unique, top-level testID for the BottomSheet and have it propagate to the header as well, which may make querying easier. Co-authored-by: Carlos Garcia * Fix indentation issue in bottom sheet component * Add change log entry * Add pull request reference to change log entry Co-authored-by: Carlos Garcia --- .../src/mobile/bottom-sheet/index.native.js | 6 ++++- .../mobile/bottom-sheet/test/index.native.js | 24 +++++++++++++++++++ packages/react-native-editor/CHANGELOG.md | 1 + 3 files changed, 30 insertions(+), 1 deletion(-) create mode 100644 packages/components/src/mobile/bottom-sheet/test/index.native.js diff --git a/packages/components/src/mobile/bottom-sheet/index.native.js b/packages/components/src/mobile/bottom-sheet/index.native.js index f6bfab39dc598c..3a0eb277bb1fc5 100644 --- a/packages/components/src/mobile/bottom-sheet/index.native.js +++ b/packages/components/src/mobile/bottom-sheet/index.native.js @@ -285,7 +285,10 @@ class BottomSheet extends Component { const { height } = nativeEvent.layout; // The layout animation should only be triggered if the header // height has changed after being mounted. - if ( this.headerHeight !== 0 && height !== this.headerHeight ) { + if ( + this.headerHeight !== 0 && + Math.round( height ) !== Math.round( this.headerHeight ) + ) { this.performRegularLayoutAnimation( { useLastLayoutAnimation: true, } ); @@ -551,6 +554,7 @@ class BottomSheet extends Component { { showDragIndicator() && ( diff --git a/packages/components/src/mobile/bottom-sheet/test/index.native.js b/packages/components/src/mobile/bottom-sheet/test/index.native.js new file mode 100644 index 00000000000000..1475943e8122c1 --- /dev/null +++ b/packages/components/src/mobile/bottom-sheet/test/index.native.js @@ -0,0 +1,24 @@ +/** + * External dependencies + */ +import { fireEvent, render } from 'test/helpers'; +import { LayoutAnimation } from 'react-native'; + +/** + * Internal dependencies + */ +import BottomSheet from '../'; + +it( 'does not animate transitions between header heights differing less than 1 pixel', () => { + const screen = render( ); + + const bottomSheetHeader = screen.getByTestId( 'bottom-sheet-header' ); + fireEvent( bottomSheetHeader, 'layout', { + nativeEvent: { layout: { height: 123 } }, + } ); + fireEvent( bottomSheetHeader, 'layout', { + nativeEvent: { layout: { height: 123.001 } }, + } ); + + expect( LayoutAnimation.configureNext ).not.toHaveBeenCalled(); +} ); diff --git a/packages/react-native-editor/CHANGELOG.md b/packages/react-native-editor/CHANGELOG.md index 71befc0d1c0e18..370ab02d93ddfc 100644 --- a/packages/react-native-editor/CHANGELOG.md +++ b/packages/react-native-editor/CHANGELOG.md @@ -16,6 +16,7 @@ For each user feature we should also add a importance categorization label to i - [**] Fix empty line apperaing when splitting heading blocks on Android 12 [#37279] - [**] Fix missing translations by refactoring the editor initialization code [#37073] - [**] Fix text formatting mode lost after backspace is used [#37676] +- [*] Fix app freeze when closing link picker while virtual keyboard is hidden [#37782] ## 1.68.0 - [**] Fix undo/redo functionality in links when applying text format [#36861] From 12bf26a7afe02039220d07d7ee97f15dd212eff9 Mon Sep 17 00:00:00 2001 From: Matthew Kevins Date: Mon, 17 Jan 2022 19:11:06 +1000 Subject: [PATCH 09/10] Update release notes --- packages/react-native-editor/CHANGELOG.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/react-native-editor/CHANGELOG.md b/packages/react-native-editor/CHANGELOG.md index 370ab02d93ddfc..db8bc2b4b89a2d 100644 --- a/packages/react-native-editor/CHANGELOG.md +++ b/packages/react-native-editor/CHANGELOG.md @@ -11,12 +11,16 @@ For each user feature we should also add a importance categorization label to i ## Unreleased +## 1.69.1 +- [*] Fix app freeze when closing link picker while virtual keyboard is hidden [#37782] +- [*] Gallery block - Fix bug when migrating from old galleries format [#37889] +- [*] RichText - Use parsed font size values when comparing new changes [#37951] + ## 1.69.0 - [*] Give multi-line block names central alignment in inserter [#37185] - [**] Fix empty line apperaing when splitting heading blocks on Android 12 [#37279] - [**] Fix missing translations by refactoring the editor initialization code [#37073] - [**] Fix text formatting mode lost after backspace is used [#37676] -- [*] Fix app freeze when closing link picker while virtual keyboard is hidden [#37782] ## 1.68.0 - [**] Fix undo/redo functionality in links when applying text format [#36861] From e0253c05e15888e951c86f36b6a32260b5baf149 Mon Sep 17 00:00:00 2001 From: Matthew Kevins Date: Thu, 20 Jan 2022 08:40:51 +1000 Subject: [PATCH 10/10] Add back missing dep in package-lock --- package-lock.json | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/package-lock.json b/package-lock.json index 27e077b7b08de8..a37b3957e426c7 100644 --- a/package-lock.json +++ b/package-lock.json @@ -19860,6 +19860,16 @@ "yauzl": "^2.7.0" }, "dependencies": { + "are-we-there-yet": { + "version": "2.0.0", + "resolved": "https://registry.npmjs.org/are-we-there-yet/-/are-we-there-yet-2.0.0.tgz", + "integrity": "sha512-Ci/qENmwHnsYo9xKIcUJN5LeDKdJ6R1Z1j9V/J5wyq8nh/mYPEpIKJbBZXtZjG04HiK7zV/p6Vs9952MrMeUIw==", + "dev": true, + "requires": { + "delegates": "^1.0.0", + "readable-stream": "^3.6.0" + } + }, "gauge": { "version": "3.0.1", "resolved": "https://registry.npmjs.org/gauge/-/gauge-3.0.1.tgz",