[Block Library - Post Excerpt]: Add attribute to show the read more link
#38662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Package] Block library
ntsekouras
requested review from
Mamaduka,
youknowriad,
scruffian,
getdave and
carolinan
|
Size Change: +123 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
I think it can be confusing that there is both a setting (even if needs to be toggled) and a separate block. |
That could be a good idea, in the form of a Both approaches though would still keep legacy code which I don't like. Maybe we could use this approach but 'hide' better these settings under advanced? 🤔 |
8 tasks
|
Flaky tests detected in 7bd7665. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4102291297
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is POC for adding a new attribute to
Post Excerptblock to hide by default theread morelink. This is because recently a new standalone Read More block link has been added, which provides more flexibility and enables more designs.Testing instructions
Post Excerptblocks should work as before(both editor and front end)read moretext set should migrate and hide the editable field in the editor. In frontend we didn't show anything anyway if it wasn't set.Post Excerptblocks and observe that the field is not visible at the insertion and is displayed if we toggle the attribute at the Inspector controls.