Update Group Block description to apply for variations #40062
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annezazu
added
[Type] Enhancement
|
Hi, |
|
Nice one, thank you Anne. The description shows up here: I'll see if I can't open a separate PR to revisit the descriptions in the inspector:
|
|
Actually scratch that separate PR, we can probably fix it here. The inspector description comes from We should either update all those separate descriptions, OR we should consider removing them. Here's what happens if the description is the same for all three variations:
☝️ I actually like that it stays "stable" like that, it makes Row and Stack just feel like versions of the Group block. Which they are. If we want to go with a singular description, the |
|
We should definitely have separate descriptions for Row and Stack to better clarify what they are for. |
|
Anne let me know if you need any help updating the separate descriptions and/or the docs. |
|
Added in some variation description updates. Curious if it strikes the right tone. I'd love help with the docs as I'm in a wrestling match with npm this morning even after full resetting. |
|
@annezazu I think you may have forgotten to push the changes you made, I'm not seeing any new descriptions in the PR. Feel free to ping me when convenient for you and I'll be happy to look again, and/or help with the npm match and docs update. |
15 tasks
|
Sorry about that 🤦🏼 Had another branch going. Updated! |
|
Size Change: +6 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
This was referenced Apr 8, 2022
This updates the Group block description to make it more applicable for the newer variations on the scene (row, stack).
jasmussen
force-pushed
the
annezazu-patch-1
branch
from
bb3d1d8 to
a679f2e
Compare
annezazu
requested review from
mkaz,
ryanwelcher and
juanmaguitar
as code owners
|
Thanks for the push. Here's the current state: The simple descriptions are nice, and I appreciate they don't cause layout shifts. I also took the liberty of rebasing to fix a merge conflict, and update the Docs as Carolina suggested. One thing though: the description, "Gather blocks in a layout container" is currently not visible anywhere but in the docs, since it's overridden in inserter and inspector by the variation descriptions. I'm happy to give this one a green check if this is the one we want to land, and I'll spin up a quick alternative based on your work here as well, just to seek out the other option. Since this PR was rebased, it'll mess things up if you just pull. Let me know if you need help, easiest is probably to delete your local branch, then pull this down fresh. |
|
Created an alternative in #40176 which uses these descriptions:
Let me know how that feels. |
|
I would make group use the same wording as the others — group doesn't have strong opinions on layout, the others do.
|
|
Took a stab at those descriptions, and the longer description for Group is causing that layout shift I worried about. Maybe it's fine?
For now I've pushed those changes to #40176. |
|
I don't mind it, I think we could look into a min-height / flex solution so that 1-3 lines render the same, and it only expands beyond 3 lines. |
|
Cool, that would benefit translations and flexibility both. We can do that as a followup. If you have a spare check we can land #40176? |
|
Hi, can this be closed? |
|
Yes. Closing. Apologies! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This updates the Group block description to make it more applicable for the newer variations on the scene (row, stack). This was found during the 6.0 walkthrough.
Why?
There are new variations (stack, row) that make the current description outdated and possibly confusing.
How?
Updates the description.