Icons Package: fix line icons styling

[arcangelini]

What?

All three line icons (lineDashed, lineDotted, lineSolid) are missing the viewbox and have hardcoded height/width and fill. This seems to be counter to what the others are set as and causes issues when passing a size to the component. I noticed this when using one of them in a project here. All the other icons are changing size except the lines.

Why?

Mostly all other icons listed in this package refrain from setting height/width and fill.

How?

Simply remove the height/width, add the viewbox, and removed the fill. Removing the height/weight is not completely necessary but I chose to do so to match the rest of the icons. The important piece is the viewbox.

Testing Instructions

I personally tested this in my project, but you can also see it in the Storybook

Screenshots or screencast

Before	After

[jasmussen]

I noticed this as well! And thank you for the PR. I'm going to CC some folks that worked on this and see if they can provide some more context. One question to pose also is: should these be part of the icon library? If they are useful enough it makes sense to fix them up like this, but if they are only ever meant to be used as part of the border controls, they could just live alongside that component directly.

[jameskoster]

Seems to be an oversight, thanks for the fix!

[aaronrobertshaw]

Thanks for fixing this @arcangelini 👍

These icons were introduced via #31585 (6500f68) and were just copied verbatim from the supplied SVG code. I don't believe there was any specific reasoning behind omitting the viewbox attribute etc and this was just an oversight as James noted.

I've tested these changes with the current uses of the icons within the block and site editors. Everything appears ok to me.