-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: Unify black color to gray-900 #40391
Conversation
Size Change: -57 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, @mirka ! It feels good to review this kind of clean-up PRs 🎉
I just noticed that the label in InputControl
(and descendant components) is still using pure black in Storybook. The reason seems to be this line of code — I quickly tried deleting it and it seemed to work fine, although I'm not sure why that rule was there in the first place 🤞
Finally, I also noticed that the changes in #40119 seem to have made it impossible to type a value interactively in the InputControl
's stories, and opened #40410 to fix that separately.
Perfect, thanks for catching and debugging (3886ff9)! I agree it looks safe to remove. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Awesome work!
Closes #40113
Related to #40387
What?
Heading
: Replace usage of#050505
with gray-900.Affected components
AlignmentMatrixControl
InputControl
Heading
SelectControl
Spinner (Experimental)
Text
Only the color reference changed and not the color value
Surface
Why?
Our default black is now gray-900, and some components had incorrect or outdated blacks.
Testing Instructions
Smoke test the affected components in Storybook.