-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish mobile, notably iPhone #4081
Conversation
This is great. It does need really thorough testing though. It's important as fixes some of the experience issues 'right now' and we can then iterate. |
overflow-y: auto; | ||
-webkit-overflow-scrolling: touch; | ||
|
||
// on mobile the main content area has to scroll |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this targeting iOS specifically? Does it impact larger-display iOS like iPads? Is the -webkit-overflow-scrolling
style unnecessary if we're intending to exclude it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm essentially normalizing the scrolling behavior across the mobile breakpoint, yes. And though the iPad also suffers from the same scrolling issue, the larger screen real estate makes the scroll issue less annoying, so it'd be good to keep the property there.
That is, scroll the `html` element, instead of a specially dedicated area. Although the latter has a ton of benefits, the former is the only thing that works stably on Mobile Safari. The thing is, there's overscroll bounce that you can't really turn off, so if you aren't scrolling the main content area things are just going to be all kinds of janky.
Also rotate ellipsis so it matches top toolbar one.
b703f12
to
76f1527
Compare
Nice work, I have some remarks:
|
- Add padding when fixed toolbar is enabled so the white sheet doesn't cover the permalink bar - Fit the permalink bar snugly to the screen edges on mobile
Going to merge in a bit unless you have last minute objections, Riad? Thanks. |
This is sort of a kitchen sink PR of small fixes. It:
body
scroll. More on this in a second.As such, the above fixes part of the issues described in #4077, notably the zooming and scrolling issues.
How Has This Been Tested?
Tested in Chrome simulator, as well as the Xcode iPhone 8 simulator.
Screenshots
Here's a video showing the iOS simulator:
https://cloudup.com/ccvLjdy6cT3
Outside of the iOS changes, which make Gutenberg usable, I'm going to open a separate ticket about modal improvements (some work to be done there). But because these changes also affect the desktop breakpoints, we should be sure to test this PR fairly widely.