Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block attributes docs: minor documentation inconsistencies #41468

Merged
merged 5 commits into from
Jun 22, 2022

Conversation

vasartam
Copy link
Contributor

What?

Resolving minor documentation inconsistencies on Block Attributes page.

Why?

It becomes slightly harder to read when the content is not structured in the same way across the whole page.

How?

This PR resolves these issues.

@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @vasartam! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label May 31, 2022
@vasartam vasartam changed the title [Type] Documentation Block attributes docs: minor documentation inconsistencies May 31, 2022
@vasartam
Copy link
Contributor Author

Hey, can't seem to add a label. Maybe I've missed the appropriate UI on the PR creation stage.

Would be cool if someone could add a "[Type] Documentation" label.

Thanks.

vasartam added 2 commits May 31, 2022 21:24
It's the source too, and other sources are placed on the `h3` level. The nested heading is also updated.
@skorasaurus skorasaurus added the [Type] Developer Documentation Documentation for developers label Jun 1, 2022
@vasartam vasartam marked this pull request as ready for review June 1, 2022 09:35
@skorasaurus
Copy link
Member

Thanks for your contribution; you didn't do anything wrong; as of now, only people that are a member of the Gutenberg team (if you make a few more contributions :)) can add labels.

Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the consistency here :)

@fabiankaegy fabiankaegy merged commit 307de23 into WordPress:trunk Jun 22, 2022
@github-actions
Copy link

Congratulations on your first merged pull request, @vasartam! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 13.6 milestone Jun 22, 2022
@skorasaurus
Copy link
Member

Looks good, thanks for your patience @vasartam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants