Tooltip: Fix jitter at edge of screen by enabling __unstableShift #41524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Bug
andrewserong
added
[Feature] UI Components
|
Size Change: +4 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Jun 3, 2022
There was a problem hiding this comment.
Nice work 👍
This is testing well for me. The approach looks consistent with the block popover's as well.
✅ Could replicate the issue on trunk
✅ This PR does resolve the problem
| Before | After |
|---|---|
Screen.Recording.2022-06-03.at.3.03.38.pm.mp4 |
Screen.Recording.2022-06-03.at.3.05.08.pm.mp4 |
There's just a minor typo in the changelog, once that's tweaked this should be right to go 🚢
Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix an issue with Tooltip where it would sometimes jitter when rendered at the edge of the screen.
Why?
As of #41402 the Popover sets
__unstableShiftasfalseby default. The Tooltip component requires this flag to render correctly, so let's opt it in.How?
Opt the Tooltip component in to using the
__unstableShiftflag in the Popover.Testing Instructions
Screenshots or screencast