Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added unit test for cover block render function #42108

Merged
merged 6 commits into from
Jul 25, 2022
Merged

Added unit test for cover block render function #42108

merged 6 commits into from
Jul 25, 2022

Conversation

akasunil
Copy link
Member

@akasunil akasunil commented Jul 3, 2022

What?

Added unit test for cover block render function.

@akasunil
Copy link
Member Author

akasunil commented Jul 4, 2022

@Mamaduka can you please review the PR.

@Mamaduka Mamaduka requested a review from draganescu July 4, 2022 05:55
draganescu
draganescu requested changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Letf two nits, but by bigger request would be to split into multiple tests as it's a bit confusing reading what we're testing.

phpunit/blocks/render-block-cover-test.php Outdated Show resolved Hide resolved
phpunit/blocks/render-block-cover-test.php Outdated Show resolved Hide resolved
draganescu
draganescu approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick, everything else LGTM

@akasunil
Copy link
Member Author

akasunil commented Jul 9, 2022

Ready to Merge ?

@Mamaduka
Copy link
Member

@sunil25393, it looks like PHP Unit tests are failing.

@akasunil
Copy link
Member Author

@sunil25393, it looks like PHP Unit tests are failing.

Can test again, I was calling wrong method of block render.

@draganescu draganescu merged commit 2e4a4c2 into WordPress:trunk Jul 25, 2022
@github-actions github-actions bot added this to the Gutenberg 13.8 milestone Jul 25, 2022
@akasunil akasunil deleted the add-test-for-cover-block-render branch July 25, 2022 14:03
@Mamaduka Mamaduka added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Block] Cover Affects the Cover Block - used to display content laid over a background image labels Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@draganescu draganescu draganescu approved these changes

Assignees
No one assigned
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
Gutenberg 13.8
Development

Successfully merging this pull request may close these issues.
3 participants
@akasunil @Mamaduka @draganescu