Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable shift in URLPopover component #42214

Merged
merged 2 commits into from
Jul 7, 2022
+4 −0
Merged

Enable shift in URLPopover component #42214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10ac4fb
Enable `shift` in URLPopover component
ntsekouras Jul 7, 2022
85b0f02
update snapshots
ntsekouras Jul 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/block-editor/src/components/url-popover/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ function URLPopover( {
className="block-editor-url-popover"
focusOnMount={ focusOnMount }
position={ position }
__unstableShift
{ ...popoverProps }
>
<div className="block-editor-url-popover__input-container">
Expand Down
3 changes: 3 additions & 0 deletions packages/block-editor/src/components/url-popover/test/__snapshots__/index.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

exports[`URLPopover matches the snapshot in its default state 1`] = `
<ForwardRef(Popover)
__unstableShift={true}
className="block-editor-url-popover"
focusOnMount="firstElement"
position="bottom center"
Expand Down Expand Up @@ -38,6 +39,7 @@ exports[`URLPopover matches the snapshot in its default state 1`] = `

exports[`URLPopover matches the snapshot when the settings are toggled open 1`] = `
<ForwardRef(Popover)
__unstableShift={true}
className="block-editor-url-popover"
focusOnMount="firstElement"
position="bottom center"
Expand Down Expand Up @@ -81,6 +83,7 @@ exports[`URLPopover matches the snapshot when the settings are toggled open 1`]

exports[`URLPopover matches the snapshot when there are no settings 1`] = `
<ForwardRef(Popover)
__unstableShift={true}
className="block-editor-url-popover"
focusOnMount="firstElement"
position="bottom center"
Expand Down