Writing flow: fix caret movement for multiple lines #42423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsf
reviewed
Jul 14, 2022
|
Size Change: +195 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
ellatrix
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
When there's multiple lines in a paragraph, it's not possible to move from the start of the second line to the start of the first line. This PR fixes that.
How?
The browser returns two rectangles for this caret position: one visually positioned at the end of the first line and one at the start of the second line. So it's not possible to know where the caret actually is. We're previously just used the first rectangle, which made it seems like the caret is at the edge (first line). We can't simply switch to using the second rectangle because then we have the problem in the other vertical direction.
So to fix this issue, we have to not use any of the rectangles the browsers gives us when it gives two of them for a collapsed selection. Without a rectangle, the caret is automatically NOT at an edge, so we just fall back to the default browser behaviour.
Testing Instructions
Screenshots or screencast