Cover block: Remove setting of default position when toggling parallax #42445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Bug
|
Size Change: -33 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
|
@matiasbenedetto it would be good to get your thoughts on this. Some of the deprecation tests are failing, but will fix those up once we decide if this way of fixing it is the best way to fix this. |
matiasbenedetto
requested changes
Jul 15, 2022
There was a problem hiding this comment.
Hi @glendaviesnz 👋 Thanks for jumping on to this!
I think we would need only to change the CSS to fix this issue. Removing the focal point as in this PR reintroduces a bug fixed in #40554 related to the default position of the focal point.
In this video, you will be able to see the bug. When you select an image and after that, you select the repeated image option, you will sell the sidebar focal point selector in the middle of the image but meanwhile, the editor is showing the image aligned top left. If you click the focal point selector in the center, as I do in the video, the image is centered in the editor too. That's why added the default focal point.
cover1.mp4
|
Thanks for the extra testing @matiasbenedetto, I knew I was probably missing some context from the original fix 😄 , I will close this in favour of #42470, and will give that a test next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the setting of a default focal point that was added in #40554
Why?
To fix a change in the zooming of fixed images that this introduced. Fixes: #42407
How?
Removes default position setting and adds additional CSS to return positioning of parallax images to pre 13.4 release
Testing Instructions
Screenshots or screencast
Before:
parallax-before.mp4
After:
parallax-after.mp4