Replace clickable div elements with buttons in the Add template modal. #42668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
Size Change: +72 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
|
This one looks straight forward. I will test this soon if no one else gets to it first. |
mirka
added
[Package] Edit Site
talldan
approved these changes
Jul 27, 2022
ciampo
reviewed
Jul 27, 2022
| > div { | ||
| text-align: center; | ||
| cursor: pointer; | ||
| > .components-button { |
There was a problem hiding this comment.
Overriding styles of a component from the @wordpress/components package this way is not ideal:
- we should not use hardcoded
@wordpress/componentsclassnames, as they are intended to be implementation details and they are not part of the components' public APIs. Instead, we should assign aclassNameto the component we'd like to target (in this case, theFlexItem), and use that new classname as the CSS selector - more in general, the amount of style overrides that are being applied to this button is worrying me a little. We should really try to limit those to a minimum (setting width/height, margin). If we find that our components can't fulfil our designs, we should discuss this mismatch and either update the designs, or update the components. Style overrides, such this specific one, can be a big obstacle to maintaining and improving the components package
I know that most of these issues existed before this PR, but it's this PR that brought this code snippet to my attention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42461
What?
Click or keyboard event should never, ever, be used on non-interactive elements like a
<div>. That would render a control that is not operable with a keyboard, as it's not focusable. The general issue has been split out to #42540. This PR seeks to fix an instance where aclickevent is attached to a<div>element in the Add template modal.Why?
In the Add template modal, the choice between creating a template for all items or for a specific item is not operable with a keyboard.
How?
Buttoncomponents.Testing Instructions
<button>elements.Screenshots or screencast