Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments Title: Add missing typography supports #43291

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Comments Title: Add missing typography supports #43291

merged 1 commit into from
Aug 18, 2022

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Adds missing typography support to the Comments Title block.

Why?

  • Improves consistency of our design tools across blocks.

How?

  • Opts into missing typography supports.

Testing Instructions

  1. Edit a post with several comments, add a Comments block and select the Comments Title.
  2. Test various typography settings ensuring styles are applied in the editor.
  3. Save and confirm the application on the frontend.
  4. Switch to the site editor, and select a page or template with a Comments block.
  5. Navigate to Global Styles > Blocks > Comments Title > Typography and apply typography styles there.
  6. Confirm the selected styles are reflected in the preview and on the frontend.

Screenshots or screencast

Screen.Recording.2022-08-17.at.11.21.35.am.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Block] Comments Title Affects the Comments Title Block [Feature] Typography Font and typography-related issues and PRs labels Aug 17, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 17, 2022
@aaronrobertshaw aaronrobertshaw mentioned this pull request Aug 17, 2022
Open
6 tasks
@carolinan carolinan merged commit 4f0f70d into trunk Aug 18, 2022
@carolinan carolinan deleted the add/missing-typography-supports-to-comments-title branch August 18, 2022 10:30
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 18, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolinan carolinan carolinan approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@aaronrobertshaw aaronrobertshaw

Labels
[Block] Comments Title Affects the Comments Title Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronrobertshaw @carolinan @femkreations