Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump React to v16 alpha #445

Merged
merged 6 commits into from
Apr 18, 2017
Merged

Bump React to v16 alpha #445

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
29358af
Bump React to v16 alpha
aduth Apr 18, 2017
65566e4
Reference ReactDOMServer as external from CDN
aduth Apr 18, 2017
8fd86c9
Bump package dependency to 16 alpha
aduth Apr 18, 2017
e25e732
Add production suffix for React CDN resource
aduth Apr 18, 2017
0a8bc8e
Mock requestAnimationFrame in test bootstrap
aduth Apr 18, 2017
421a4cd
Use react-autosize-textarea instead of react-textarea-autosize
aduth Apr 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,9 @@ function gutenberg_register_scripts() {
$suffix = SCRIPT_DEBUG ? '' : '.min';

// Vendor
wp_register_script( 'react', 'https://unpkg.com/react@15/dist/react' . $suffix . '.js' );
wp_register_script( 'react-dom', 'https://unpkg.com/react-dom@15/dist/react-dom' . $suffix . '.js', array( 'react' ) );
$react_suffix = ( SCRIPT_DEBUG ? '.development' : '' ) . $suffix;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we fallback to .production to avoid errors

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we fallback to .production to avoid errors

Yes, added in e25e732.

wp_register_script( 'react', 'https://unpkg.com/react@next/umd/react' . $react_suffix . '.js' );
wp_register_script( 'react-dom', 'https://unpkg.com/react-dom@next/umd/react-dom' . $react_suffix . '.js', array( 'react' ) );

// Editor
wp_register_script( 'tinymce-nightly', 'https://fiddle.azurewebsites.net/tinymce/nightly/tinymce.min.js' );
Expand Down