REST API: Do not set sidebar status to 'active' when using classic theme #46966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Bug
|
@justintadlock: Could we please cut a Gutenberg 14.9.1 release with this PR in it? |
4 tasks
fullofcaffeine
pushed a commit
that referenced
this pull request
Jan 9, 2023
85 tasks
DaisyOlsen
removed
the
Backport to Gutenberg Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why? How?
Fixes an error in #45509. See #45509 (comment).
The previous code would set
status = 'inactive'on the sidebar when using a block theme andstatus = 'active'when using a classic theme. It is correct to setstatus = 'inactive'when using a block theme but if using a classic theme thenstatusshould not be changed.Testing Instructions
Same as in #45509.