Fully remove Navigation Editor screen and associated edit-navigation package
#47055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
requested review from
spacedmonkey,
ntwb,
nerrad,
ajitbohra,
draganescu,
talldan,
tellthemachines,
adamziel and
kevin940726
as code owners
getdave
changed the title
edit-navigation package
getdave
added
Needs Dev Note
|
Size Change: -24.5 kB (-2%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 088fa19. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3892435133
|
|
Makes sense to remove it. I imagine if the Navigation screen is picked back up that it'd be a completely different implementation that relies more heavily on the Navigation block and its block inspector. Plus can always look at git history to copy any code that we want to reuse. Some of the test failures seem genuine. I think some E2E snapshots need to be updated. Pinging @youknowriad in case he has any lessons to share about removing a package. (He removed This package never made it into Core so there shouldn't be any backwards compatibility concerns about removing it. If tests pass then this lgtm. |
|
Yeh I'll sort those tests out soon. Thanks @noisysocks |
|
Looks good to me, especially since this was never a core package 👍 |
getdave
force-pushed
the
remove/edit-navigation-package
branch
from
f4eb5e6 to
dc641b7
Compare
|
Ok this is good to go 🤞 @scruffian can you ✅ based on the feedback from others above? |
draganescu
reviewed
Jan 26, 2023
| @@ -43,6 +43,7 @@ exports[`getChangelog verify that the changelog is properly formatted 1`] = ` | |||
| - Fix block appender position in classic themes. ([33895](https://github.com/WordPress/gutenberg/pull/33895)) | |||
| - Fix misspelling of \\"queries\\" in filter documentation. ([33799](https://github.com/WordPress/gutenberg/pull/33799)) | |||
| - Fix positioning discrepancy with draggable chip. ([33893](https://github.com/WordPress/gutenberg/pull/33893)) | |||
| - Navigation Editor: Avoid React warning when creating a new menu. ([33843](https://github.com/WordPress/gutenberg/pull/33843)) | |||
There was a problem hiding this comment.
What is this line about in this PR?
Dev note for WP 6.2Removal of the Navigation Editor screen and associated packageThe Navigation Editor screen was an experimental feature of the Gutenberg Plugin that contributors worked on as a potential replacement for the classic As the Gutenberg Navigation project has evolved however, the requirement for a dedicated screen has become less pronounced, with features originally proposed for/included within the screen being incorporated into the Navigation block itself. During the 6.1 cycle, due to lack of contributions, the experiment was informally deprecated in the Plugin by being removed from the With the arrival of list view editing for the Navigation block in WordPress 6.2, menus can now be edited away from the editor canvas, and therefore it is finally time to formally remove the experiment from the codebase. The |
|
@talldan @draganescu Would you mind reviewing the above for accuracy/spelling/grammar .etc? Much appreciated. |
|
It sounds good to me 👍 |
bph
added
has dev note
|
Thanks for the Dev Note @getdave - I added it to the Miscellaneous Editor Changes in 6.2 post. (Public post preview link) |
ockham
added a commit
that referenced
this pull request
Aug 10, 2023
`git bisect` revealed that [the last known use of that function](https://github.com/WordPress/gutenberg/pull/47055/files#diff-bb9ee7c63178059379505a610c303b5b11c1bc38b0961ae3cee952c68d897256L110-L118) was in `lib/experimental/navigation-page.php`, which was removed in #47055, alongside a lot of other code. It was probably by oversight that `gutenberg_initialize_editor` was left behind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the Navigation Editor screen from codebase and removes
@wordpress/edit-navigationscreen.Closes #43620
Why?
For some time now this screen has been:
As there are no plans to continue working on this concept it's time to remove it and the associated package.
Note that many learnings were taken from the work on this package which have since been applied to other projects surrounding Navigation. But...it's time to let it go 😢
How?
Removes all file references.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast