Shadow: move shadow into own panel #47634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +338 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 1897238. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4072472958
|
|
Separating "Border & Shadow" seems like a good move. It's not a strong feeling but personally I would favor a dedicated Shadow panel for now, then renaming to "Effects" when we actually add more features. |
madhusudhand
force-pushed
the
shadow-effects
branch
from
abffa6e to
1897238
Compare
|
Renamed the label Effects to Shadow
|
Happy to try that, but just to confirm the context that the goal here is to have the same drilldown properties in Global Styles, as blocks have panels. Previously this diverged sligthly, with border found inside "Layout". |
mikachan
approved these changes
Feb 2, 2023
There was a problem hiding this comment.
This LGTM, but would be good to get a 👍 from @jameskoster and/or @jasmussen too!
jameskoster
approved these changes
Feb 2, 2023
madhusudhand
changed the title
madhusudhand
added
the
Backport to WP 6.7 Beta/RC
ntsekouras
pushed a commit
that referenced
this pull request
Feb 7, 2023
* move shadow into newly created effects panel * rename effects to shadow * rename label shadows to shadow in popover
|
Cherry-picked this PR to the wp/6.2 branch. |
ntsekouras
added
[Type] Bug
DaisyOlsen
added
the
[Feature] Site Editor
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This change moves the shadow from "Border & Shadow" to new panel "Effects".
Why?
Right now the panel is called
Border & Shadow, and it remains same even though a block doesn't haveshadowsupport enabled which is misleading. Instead move it to different menu so it appears only for the support enabled blocks.reference to the latest design discussions on shadow placement here, and start a discussion to check if its a good idea to apply the same in global styles.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
@WordPress/gutenberg-design
Related to #44651