Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Only fetch wp_navigation menus once #49143

Closed
wants to merge 1 commit into from
Closed

Navigation: Only fetch wp_navigation menus once #49143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/block-library/src/navigation/use-navigation-menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,9 @@ function selectNavigationMenus( select ) {
const args = [
'postType',
'wp_navigation',
{ per_page: -1, status: [ 'publish', 'draft' ] },
{ per_page: -1, status: 'publish,draft' },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamziel Do you have any idea why this might be the case? Seems like a bug in the underlying implementation of Core Data.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked into what might be going on here. It doesn't seem to make a difference in the final query before the rest api WP_Query happens. The comma separated string gets transformed into an array before the WP_Query. This image shows the status array query vs string query end up being identical.

Screenshot 2023-03-16 at 3 54 28 PM

I dumped the $query_args with die() after it if it was a navigation request to see the params here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be misunderstanding where to look test this at. I would add a new post, then add a navigation block to the page.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scruffian If we do this we will need a comment to explain why it has to be a string for now.

];

return {
navigationMenus: getEntityRecords( ...args ),
isResolvingNavigationMenus: isResolving( 'getEntityRecords', args ),
Expand Down