Navigation: Apply color classes to the navigation container element #50968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 25, 2023
Closed
| @@ -524,7 +524,7 @@ function render_block_core_navigation( $attributes, $content, $block ) { | |||
|
|
|||
| if ( $is_list_item && ! $is_list_open ) { | |||
| $is_list_open = true; | |||
| $inner_blocks_html .= '<ul class="wp-block-navigation__container">'; | |||
| $inner_blocks_html .= '<ul class="wp-block-navigation__container '.implode( ' ', $classes ).'">'; | |||
There was a problem hiding this comment.
this will only work for preset colors, not custom ones, sadly
|
Flaky tests detected in 299b146. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5081878086
|
MaggieCabrera
approved these changes
May 25, 2023
Co-authored-by: Maggie <3593343+MaggieCabrera@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Makes the navigation submenu blocks inherit their color from the navigation block. Fixes #50235
Why?
On trunk when a navigation block sets a background color the submenus lose their color which cases issues like #50235.
How?
We just needed to add the right classes to the container block.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Props to @MaggieCabrera who found the issue.