Details Block: Remove experimental flag and stabilize #50997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
Gutenberg Plugin
|
Size Change: -52 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
|
Thanks for handling this ❤️ Removing the edit: oh, just read the PR description properly. I think it's ok to remove that Probably the same for Time to Read (best in a separate PR). I'm not so sure on the status of Table of Contents. |
Personally, I think it would be better to discuss with more people on a separate issue whether or not to ship this block to the core. Stabilizing the Table of Contents is discussed in #42229. We also need to consider separately regarding the Time to Read block 😅 |
|
Flaky tests detected in 7bc8e5c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5089153328
|
One of the best ways to test these new features is to include them in the 6.3 beta. If it's decided they're not ready they can be removed from the beta. On the other hand, if we (as gutenberg contributors) accidentally leave it too late to remove the experimental setting, then it becomes very difficult to include them in the beta because of the feature freeze. The release leads have to be persuaded to bless the inclusion of the blocks, and it's a very uncomfortable drawn-out process for everyone. |
|
I see, so let's remove the experimental flag 👍 |
t-hamano
requested review from
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
t-hamano
changed the title
carolinan
approved these changes
May 26, 2023
|
Alright, so let's merge this PR and get more feedback on the WordPress 6.3 beta! |
12 tasks
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Details Block: Enable by default on Gutenberg plugin without opt-in * Add fixture * Stabilize the block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #50526
What?
This PR makes the Details block the default on the Gutenberg plugin without opt-in.
Why?
The other blocks (Time To Read, Table of Contents) with
__experimental:truein block.json are enabled by default on the Gutenberg plugin. I think we should first make it available by default on the Gutenberg plugin in order to aim to ship to the WordPress core.Also, the problem on Firefox should have been fixed by #50540.
Testing Instructions