Fixed a series of z-index sidebar related issues #5165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pear in front of the sidebar on mobile.
jorgefilipecosta
added
[Type] Bug
|
This seems a massive improvement over what was here before. Thank you! 👍 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a series of issues where editor elements appear above the sidebar in resolutions between 600 and 782px.
How Has This Been Tested?
Most tests should be executed on a resolution between 600 and 782. The test describes the problem happening on master right now.
Go to the target resolution, open the sidebar, make the window big (> 782 px). Add a block, press the block settings menu, resize to the target resolution again, see the block setting menu is not above the sidebar.
Add a galley in the target resolution, select an image, open the sidebar and verify the remove image icon is not above the sidebar.
Add a button in the target resolution, go to the URL input see some suggestions, open the sidebar verify the suggestions and the formatting toolbar is not above the sidebar.
Add an invalid block in the target resolution, e.g: add a paragraph and in the code view change the code to
. Open the sidebar, see the invalid block warning is not above the sidebar.Screenshots (jpeg or gifs if applicable):