From 7365bf51e8d8f119cc9fc3c1af2f5de02e861142 Mon Sep 17 00:00:00 2001 From: Riad Benguella Date: Thu, 28 Sep 2023 14:16:16 +0100 Subject: [PATCH 1/2] Popover: Fix the styles for components that use emotion within popovers --- packages/components/src/popover/index.tsx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/components/src/popover/index.tsx b/packages/components/src/popover/index.tsx index 19e0daeb79d126..19df26e0777ee1 100644 --- a/packages/components/src/popover/index.tsx +++ b/packages/components/src/popover/index.tsx @@ -60,6 +60,7 @@ import type { PopoverAnchorRefTopBottom, } from './types'; import { overlayMiddlewares } from './overlay-middlewares'; +import { StyleProvider } from '../style-provider'; /** * Name of slot in which popover should fill. @@ -447,7 +448,10 @@ const UnforwardedPopover = ( if ( shouldRenderWithinSlot ) { content = { content }; } else if ( ! inline ) { - content = createPortal( content, getPopoverFallbackContainer() ); + content = createPortal( + { content }, + getPopoverFallbackContainer() + ); } if ( hasAnchor ) { From a180b6a2af87a44a06c2234da57042aabe842bb6 Mon Sep 17 00:00:00 2001 From: Riad Benguella Date: Fri, 29 Sep 2023 09:00:04 +0100 Subject: [PATCH 2/2] Add changelog entry --- packages/components/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index 6f9291d27e1cdc..ba4ae73a65783e 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -16,6 +16,7 @@ - `FormTokenField`: Add `box-sizing` reset style and reset default padding ([#54734](https://github.com/WordPress/gutenberg/pull/54734)). - `SlotFill`: Pass `Component` instance to unregisterSlot ([#54765](https://github.com/WordPress/gutenberg/pull/54765)). - `Button`: Remove `aria-selected` CSS selector from styling 'active' buttons ([#54931](https://github.com/WordPress/gutenberg/pull/54931)). +- `Popover`: Apply the CSS in JS styles properly for components used within popovers. ([#54912](https://github.com/WordPress/gutenberg/pull/54912)) ### Internal