Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changelog entry for #54415 #55201

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Add changelog entry for #54415 #55201

merged 3 commits into from
Oct 11, 2023

Conversation

aristath
Copy link
Member

What?

Adds a changeling entry for #54415. This should have been included in the original PR but was missed, so this is just a followup.

@aristath aristath requested a review from ciampo October 10, 2023 11:30
@aristath aristath mentioned this pull request Oct 10, 2023
Merged
@ciampo
Copy link
Contributor

ciampo commented Oct 10, 2023

The CHANGELOG I was referring to is the one specific to the @wordpress/components package — could you move the entry there?

Apologies for not having been clear before.

@aristath aristath requested a review from ajitbohra as a code owner October 11, 2023 06:33
@aristath aristath added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Oct 11, 2023
@aristath
Copy link
Member Author

@ciampo that makes more sense... Thank you for the clarification!
Moved the entry 👍

@github-actions
Copy link

Flaky tests detected in 4cd46fd.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6478856696
📝 Reported issues:

ciampo
ciampo approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@aristath aristath enabled auto-merge (squash) October 11, 2023 14:19
@aristath aristath merged commit bdfb93e into trunk Oct 11, 2023
49 of 50 checks passed
@aristath aristath deleted the add/54415-changelog branch October 11, 2023 15:02
@github-actions github-actions bot added this to the Gutenberg 16.9 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciampo ciampo ciampo approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
Gutenberg 16.9
Development

Successfully merging this pull request may close these issues.
2 participants
@aristath @ciampo