Update: Remove path awareness from data-views specific code. #55695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -11 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in a6adbad. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6691812336
|
|
Merging this as it is a simple change that will be part of a bigger follow-up PR. |
jorgefilipecosta
deleted the
update/remove-path-awareness-from-dataviews-specific-code
branch
jorgefilipecosta
added
the
[Type] Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a comment by @ntsekouras at #55465 (comment), and removes path awareness from dataviews-specific code (e.g: code inside packages/edit-site/src/components/dataviews/).
After this change, the provider only receives a type of dataview e.g.: page or product. The edit site code using the provider is the one that checks the path and depending on the path passes the correct type.
Testing
Verify data views continue to work as expected and are correctly persisted.