Add context for translators to any unclear usage of "synced" #55935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
@kebbet How do these translator comments look to you? Also as a general note, I think it's too late to get this into 6.4 (release is scheduled for today?), so I've add it as a backport for 6.4.1. |
|
Size Change: +190 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
talldan
commented
Nov 7, 2023
|
Comments themself looks ok, but could gutenberg/packages/block-editor/src/components/global-styles/hooks.js Lines 380 to 383 in a82dedf This way the string becomes unique in the translation GUI/database. |
Ping @talldan, and thanks for working on this. 6.4.1 would be nice target! |
|
Flaky tests detected in 6ad4a7a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6845336470
|
Thanks for the feedback, I'll follow up with those changes tomorrow 👍 |
|
I've updated this taking the feedback into account. |
aaronrobertshaw
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
LGTM 🚢
✅ Code changes look good
✅ Labels display correctly while smoke testing
Thanks for these improvements @talldan 👍
talldan
force-pushed
the
fix/i18n-context-for-synced
branch
from
4395fcb to
6ad4a7a
Compare
mikachan
pushed a commit
that referenced
this pull request
Nov 13, 2023
* Add context for translators to any unclear usage of synced * Remove toggle in translator comment * Use _x
|
I just cherry-picked this PR to the 6.4-next-point-release branch to get it included in the next release: 3c1c897 |
mikachan
removed
the
Backport to WP Minor Release
mikachan
pushed a commit
that referenced
this pull request
Nov 13, 2023
* Add context for translators to any unclear usage of synced * Remove toggle in translator comment * Use _x
cbravobernal
pushed a commit
that referenced
this pull request
Nov 14, 2023
* Add context for translators to any unclear usage of synced * Remove toggle in translator comment * Use _x
oandregal
added
the
[Feature] Patterns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #55783
As mentioned in that issue, it's unclear if the word "synced" is singular or plural and this can result in incorrect translations.
How?
Add a translator comment explaining each usage of the word 'synced'.