Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing block: use raw source for originalContent #56014

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Missing block: use raw source for originalContent #56014

merged 1 commit into from
Nov 14, 2023

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Nov 9, 2023 •
edited
Loading

What?

The raw source is meant exactly for the raw, original, unmodified content, while html may be modifying the content (innerHTML converts a lot of characters to HTML entities). See #27268 for the HTML block.

Why?

originalContent means that the content shouldn't be modified.

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@ellatrix ellatrix requested a review from ajitbohra as a code owner November 9, 2023 21:43
@ellatrix ellatrix added the [Type] Bug An existing feature does not function as intended label Nov 9, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

Flaky tests detected in 3adb118.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6817770916
📝 Reported issues:

@gziolo gziolo added the [Package] Block library /packages/block-library label Nov 10, 2023
Mamaduka
Mamaduka approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense and matches the recent changes to Freeform/Shortcodes blocks - #51123.

@ellatrix
Copy link
Member Author

Thank you!

@ellatrix ellatrix merged commit f137d97 into trunk Nov 14, 2023
53 checks passed
@ellatrix ellatrix deleted the fix/missing-raw-original-content branch November 14, 2023 14:06
@github-actions github-actions bot added this to the Gutenberg 17.1 milestone Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Package] Block library /packages/block-library [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 17.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ellatrix @Mamaduka @gziolo