Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/5644 Adding custom CSS support in Latest Posts Block #5649

Closed
wants to merge 1 commit into from
Closed

Issue/5644 Adding custom CSS support in Latest Posts Block #5649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions blocks/library/latest-posts/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ function render_block_core_latest_posts( $attributes ) {
$class .= ' columns-' . $attributes['columns'];
}

if ( isset( $attributes['className'] ) && ! empty( $attributes['className'] ) ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using empty() means that isset() isn't needed. This could be simplied to just:

if ( ! empty( $attributes['className'] ) ) {.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch and it encouraged me to take a bit deeper look at this.
ATM $attributes['className'] can return NULL, an empty string or a string that was populated by a user.

Considering that "0" is a valid string that theoretically can be used by a user as a custom class empty() won't be enough as it will validate it to false.

Also as it's a user input where you can expect unexpected I should have been sanitized it. ie if I put <script>alert(1)</script> as a custom class I get an alert prompt on the front-end. Shame on me!

To sum up, I think that the conditional should have a similar shape to what you can see below, but holding off for now because of the other comments.

$custom_class = wp_strip_all_tags( $attributes['className'] );
if ( isset( $custom_class ) && $custom_class !== '' ) {
	$class .= ' ' . $custom_class;
}

$class .= ' ' . $attributes['className'];
}

$block_content = sprintf(
'<ul class="%1$s">%2$s</ul>',
esc_attr( $class ),
Expand Down Expand Up @@ -102,6 +106,9 @@ function register_block_core_latest_posts() {
'type' => 'string',
'default' => 'date',
),
'className' => array(
'type' => 'string',
),
),
'render_callback' => 'render_block_core_latest_posts',
) );
Expand Down