Enter zoom-out mode when selecting patterns in the inserter #56772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Experimental
kevin940726
changed the base branch from
trunk
to
try/zoomed-out-mode-experiments
|
Size Change: +92 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
kevin940726
force-pushed
the
try/enter-zoom-out-mode-when-opening-patterns
branch
from
b5c049d to
19c6cbc
Compare
kevin940726
force-pushed
the
try/enter-zoom-out-mode-when-opening-patterns
branch
from
19c6cbc to
f0bff10
Compare
kevin940726
added
the
[Feature] Inserter
talldan
approved these changes
Dec 6, 2023
talldan
merged commit bf2f441
into
try/zoomed-out-mode-experiments
52 of 54 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Addresses #44585.
Why?
See #44585.
How?
Due to that the inserter works as a dialog, it closes itself if the focus changes. It conflicts with the vision of (only) auto-enabling zoom-out mode when the inserter is opened, because interacting with anything in the zoom-out mode will change the focus and thus close the inserter (and exit zoom-out mode).
This PR disables the close on focus outside feature for now, until we find a better interactions for the zoom-out mode.
Testing Instructions
Screenshots or screencast
Kapture.2023-12-06.at.16.22.58.mp4