Image Block: Change upload icon label #57704
Merged
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Copy
t-hamano
requested review from
kevin940726,
Mamaduka,
artemiomorales and
michalczaplinski
as code owners
|
Size Change: -1 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
@Mamaduka Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56345
What?
This PR updates the label of the external image upload icon in the block toolbar of the Image Block.
Before
After
Why?
When you publish a post, the pre-publish check will ask you if you want to upload external images to the media library.
This panel has a description so it's easy to understand what the "Upload" button actually does.
But the block toolbar has no such context, so users may be confused about where to upload images.
How?
Maybe it should be "Upload external image to media library" to provide full context. However, I excluded the word "external" because I don't want the tooltip text to be too long.
Testing Instructions